search

tinyzimmer / go-gst

Gstreamer bindings and utilities for golang
GNU Lesser General Public License v2.1
130 stars 37 forks source link

Add support for gstreamer 1.16 by putting 1.18 specific stuff behind a build tag #35

Open nielsavonds opened 2 years ago

nielsavonds commented 2 years ago

For backward compatibility, when building without any build tags, the latest gstreamer version is assumed.

tinyzimmer commented 2 years ago

Thanks for doing this, it was desperately needed. I'll want some time to play with it, but I'll get back to you.

nielsavonds commented 2 years ago

No problem! Let me know if anything needs to be changed or if you think it makes more sense to put things behind a gst118 flag instead.

tinyzimmer commented 2 years ago

Sorry for the delay. This looks good and works really well. The only thing I'm thinking is adding a couple lines to the README about how to use the tags. Not super critical though. I could do that later.

RSWilli commented 1 year ago

@nielsavonds please recreate this PR for https://github.com/go-gst/go-gst (where future development of the bindings will take place) if you think it is necessary.

This also raises the question posed in https://github.com/go-gst/go-gst/issues/13#issuecomment-1691256106 for which gstreamer version do need support. Since this PR was created some time passed and gstreamer 1.22.0 is widely available. Is this PR still relevant?