tipsi / tipsi-stripe

React Native Stripe binding for iOS/Android platforms
MIT License
1.14k stars 527 forks source link

Showing "Manifest merge failed error" #837

Closed Hari-krish-v closed 1 year ago

Hari-krish-v commented 2 years ago

When I installed tipsi-stipe package and run the project I get the below error message "Manifest merger failed : android:exported needs to be explicitly specified for . Apps targeting Android 12 and higher are required to specify an explicit value for android:exported when the corresponding component has an intent filter defined"

Added android:exported="true" on Main/AndroidManifest.xml file inside activity tag

Below are the versions details. "react": "17.0.2", "react-native": "0.68.0", "tipsi-stripe": "^9.2.0"

    buildToolsVersion = "31.0.0"
    minSdkVersion = 21
    compileSdkVersion = 31
    targetSdkVersion = 31
    ndkVersion = "21.4.7075529"
imariic commented 2 years ago

@Hari-krish-v Have you managed to fix it?

imariic commented 2 years ago

Okay, I've managed to fix it by using tipsi-stripe:9.0.0

Hari-krish-v commented 2 years ago

I have updated to the latest version then also it showing the same error "Manifest merge failed"

felexx90 commented 2 years ago

@Hari-krish-v I added this as a workaround to my AndroidManifest.xml

 <activity
      android:name="com.stripe.android.payments.StripeBrowserLauncherActivity" android:exported="true" 
       tools:node="merge"/>
mtr1012 commented 2 years ago

@Hari-krish-v I added this as a workaround to my AndroidManifest.xml

 <activity
      android:name="com.stripe.android.payments.StripeBrowserLauncherActivity" android:exported="true" 
       tools:node="merge"/>

Thank you so much. Save me a lot of time @felexx90

gabriellend commented 2 years ago

@Hari-krish-v I added this as a workaround to my AndroidManifest.xml

 <activity
      android:name="com.stripe.android.payments.StripeBrowserLauncherActivity" android:exported="true" 
       tools:node="merge"/>

I was trying to find a solution for a week for this, THANK YOU BLESS YOU!

itsAyyazdev commented 2 years ago

<activity android:name="com.stripe.android.payments.StripeBrowserLauncherActivity" android:exported="true" tools:node="merge"/>

You are a lifesaver bro, I was struggling to fix this for the last 4 days. Your solution worked. Thank you.

RaviPrakash040398 commented 2 years ago

@Hari-krish-v I added this as a workaround to my AndroidManifest.xml

 <activity
      android:name="com.stripe.android.payments.StripeBrowserLauncherActivity" android:exported="true" 
       tools:node="merge"/>

Thank you.

GabrielJorge94 commented 1 year ago

@Hari-krish-v I added this as a workaround to my AndroidManifest.xml

 <activity
      android:name="com.stripe.android.payments.StripeBrowserLauncherActivity" android:exported="true" 
       tools:node="merge"/>

I only had to add the xmlns:tools="http://schemas.android.com/tools" into my AndroidManifest.xml and it worked just perfect! Thanks @felexx90 you saved me a lot of time.

kavindadilshan commented 1 year ago

@Hari-krish-v I added this as a workaround to my AndroidManifest.xml

 <activity
      android:name="com.stripe.android.payments.StripeBrowserLauncherActivity" android:exported="true" 
       tools:node="merge"/>

You are a hearo brother.You saved my time

aharodnikau commented 1 year ago

@felexx90, app builds success, but crashes on entering. Which place should I add this activity in? Maybe I do smth wrong

xDemon200 commented 1 year ago

@Hari-krish-v I added this as a workaround to my AndroidManifest.xml

 <activity
      android:name="com.stripe.android.payments.StripeBrowserLauncherActivity" android:exported="true" 
       tools:node="merge"/>

Thanks. :)

fbartho commented 1 year ago

Closing this ticket, so that new users don't think this project is still active.

Stripe does not want you using this, and you will find pain if you do; Please migrate to the official @stripe/stripe-react-native package, for your user's safety, and your developer's sanity!

See more: https://github.com/tipsi/tipsi-stripe/issues/842

ShoaibVirk008 commented 8 months ago

I was facing the same error and tried this

<activity android:name="com.stripe.android.payments.StripeBrowserLauncherActivity" android:exported="true" tools:node="merge"/>

But then got another error, after some research found the solution, which was same above line of code but without "tools:node="merge"",

Like this

<activity android:name="com.stripe.android.payments.StripeBrowserLauncherActivity" android:exported="true" />

fbartho commented 8 months ago

I can’t emphasize enough how you should move off of tipsi-stripe @ShoaibVirk008. This is a security vulnerability, and I hope I never again use an app that still uses tipsi-stripe today, as of 2023.