Closed fiznool closed 1 year ago
@fiznool honestly, I can merge it.
But we're relying that you've tested it and everything works without testing on my side it
I've tested the native payment methods and paymentRequestWithCardForm which all work fine. I think, given the nature of Apple's forthcoming policy, coupled with the fact this is a major release bump, publishing this as v11.0.0 with the small potential for issues is preferable to people not being able to submit app updates.
@fiznool ok, going to rollout it thank you!
Firstly, I understand that this library is no longer maintained, and so I'm aware that this might never get merged in. However, there is an issue with the library as it stands, meaning that it will not build against the iOS 16 SDK. This is a problem since starting April 25, Apple mandate that all submissions to the App Store must be built against the iOS 16 SDK or later.
The underlying reason that the library does not support iOS 16 is due to the stripe-ios dependency, which is currently set at v21. Updating to v22 fixes this issue, but this also necessitates a bump of the minimum supported version of iOS to 12. This is why the changes in this PR also include a bump to the major package version of this library, as technically this is a breaking change for users who currently target iOS 11.
For those of us that need to incorporate these changes before (if?) the PR is merged, I would recommend using the excellent
patch-package
tool, with the following patch: