search

tipsy / j2html

Java to HTML generator. Enjoy typesafe HTML generation.
https://j2html.com/
Apache License 2.0
765 stars 136 forks source link

Adding Automatic-Module-Name to manifest to support JDK 9+. #183

Closed sembler closed 3 years ago

sembler commented 3 years ago

Using project-name (j2html) convention for module, which also matches package naming. There are a lot of recommendations towards using the reverse-DNS (com.j2html) naming convention. But that does not match our current package naming, and may force a breaking change later. Another consideration is that other projects like Spring and Hibernate seem to be fine with project-naming.

@tipsy , @obecker do you have any concerns with this approach?

obecker commented 3 years ago

@sembler, actually I have no strong opinion about that. However, in the long run I think it makes sense to use com.j2html for both the base package name and the module name.

sembler commented 3 years ago

I also have no strong opinions. com.j2html was my initial approach too. We'll just need to remember to change package naming in v2.0.