search

tipsy / profile-summary-for-github

Tool for visualizing GitHub profiles
https://profile-summary-for-github.com/
Apache License 2.0
19.84k stars 501 forks source link

Make Clicking "Unknown" Language Do Nothing. #112

Closed Attacktive closed 2 years ago

Attacktive commented 2 years ago

It's a possible solution to #97.

Unknown here is actually a representation of null.

Passing query string language=Unknown (or any arbitrary language) to the user repositories tab is currently equivalent to passing none, so I decided not to open anything when Unknown is clicked.

Plus, I added some text to the tooltip in order to prevent confusion: image image image Those screenshots are taken from @ajmeese7's profile summary. 😁

I suppose it's safe until a language named Unknown gets popular enough.

ajmeese7 commented 2 years ago

@Attacktive this looks awesome, thanks for the fix!

tipsy commented 2 years ago

Seems I missed this, thanks !