tipsy / profile-summary-for-github

Tool for visualizing GitHub profiles
https://profile-summary-for-github.com/
Apache License 2.0
19.83k stars 494 forks source link

Change Cache to Embedded H2 #113

Closed Attacktive closed 2 years ago

Attacktive commented 2 years ago

It resolves #110.

As a Kotlin noob, I am not sure if it's good enough but my two cents here.

I chose H2 only because I'm kind of familiar with it. Switching to another like Nitrite or Derby shouldn't be a big deal.

You can enable the console by making a few changes.

I decided to have a single table with a JSON column which contains every bit of information in one out of laziness. πŸ˜’

Attacktive commented 2 years ago

Thank you so much, @iProdigy. I'll be working on it soon.

Attacktive commented 2 years ago

Thank you sooo much, @iProdigy for helping me learn to code in Kotlin.

iProdigy commented 2 years ago

Thank you sooo much, @iProdigy for helping me learn to code in Kotlin.

my pleasure! thanks for bearing with my nits

tipsy commented 2 years ago

Thanks @iProdigy and @Attacktive, I will have a look in the weekend !

tipsy commented 2 years ago

@Attacktive there seems to be a lot of changes here that are unrelated to the caching (particularly in UserService), is that correct?

Attacktive commented 2 years ago

@Attacktive there seems to be a lot of changes here that are unrelated to the caching (particularly in UserService), is that correct?

Ah, the changes in UserService might look excessive, but actually they mostly are:

That's about it. 😁

tipsy commented 2 years ago

That's about it. 😁

Perfect! Nice work @Attacktive, thank you very much ☺️