Caching parameters are for MySQL not H2

[brettwooldridge]

I noticed that the caching parameters are copy-pasted from the HikariCP example initialization code, and as a result the caching parameters are relavent for MySQL, not H2.

https://github.com/tipsy/profile-summary-for-github/blob/123a10bed434b050466bb94cd515034d3d182b7b/src/main/kotlin/app/util/HikariCpDataSource.kt#L12-L14

Documentation for available H2 properties is here: https://www.h2database.com/javadoc/org/h2/engine/DbSettings.html#queryCacheSize

According to those docs, enabling statement caching would look like this:

private const val urlToDb = "jdbc:h2:mem:userinfo;QUERY_CACHE_SIZE=250"

(I am the author of HikariCP)

[iProdigy]

Good catch, thank you! Will correct this shortly

[tipsy]

Thanks @brettwooldridge! (also thank you for HikariCP, I use it a lot)