Cache improvements - Githubissues

tipsy / profile-summary-for-github

Tool for visualizing GitHub profiles

https://profile-summary-for-github.com/

Apache License 2.0

19.83k stars 494 forks source link

Cache improvements #91

Closed iProdigy closed 6 years ago

iProdigy commented 6 years ago

Storage

Queue up storage tasks to a separate thread for file i/o
Use a ConcurrentHashMap in case of simultaneous profile saves (was a non-synchronized LinkedHashMap)

Retrieval

Use let to auto close resources
Better exception handling (mostly relevant when serial version uid changes)

Reading

ConcurrentHashMap uses less memory than LinkedHashMap
Map#get on ConcurrentHashMap is faster

tipsy commented 6 years ago

This seems a bit excessive? 🤔

iProdigy commented 6 years ago

i think it's necessary if javalin is handling requests in a multi-threaded manner (one thread modifying linkedhashmap while others access is a problem and multiple threads trying to save file is another)

david-wg2 commented 6 years ago

I guess it's more responsible to do things properly. I'm on a business trip right now, but I'll merge it when I get home later this week.

iProdigy commented 6 years ago

No worries - have a good business trip!

tipsy commented 6 years ago

have a good business trip!

Thanks, and thanks for the PR.