search

tiredofit / docker-leantime

Dockerized Project Managment tool with many configurable options
MIT License
16 stars 4 forks source link

Set rewrite rules to upstream default and fix storage issues #11

Closed ArjenR closed 1 year ago

ArjenR commented 1 year ago

This is my fix for #9 There was some looping going on. I changed all rewrites for nginx to the upstream example which was updated some time ago. Works for me.

2nd fix is for not using the local file storage due to an uninitialized s3_enabled when testing to use S3 storage, I guess it us php or due to the function that tests for true/false, I have very little php experience. But testing for a not existing variable resulted in it being evaluated to TRUE. Call me surprised. I undid my earlier fix which was more cosmic.

3rd fix for a not working symlink for public userfiles which is used to store the logo. I made a change to create a public folder and not use the existing storage for non-public userfiles. Otherwise you could hypothetically brute-force/fuzz for files files stored there without logging in. I have not yet grasped your other changes for the whole storage of either userfiles or all data, so it might break something else...

Also it is not my intention to have multiple fixes in one pull request. That is me being not proficient in git and github.

tiredofit commented 1 year ago

Thanks for this! I appreciate your work to clean up the mess I've created!