search

tiredofit / docker-leantime

Dockerized Project Managment tool with many configurable options
MIT License
16 stars 4 forks source link

Fix for two issues I had to get leantime working for me. #6

Closed ArjenR closed 1 year ago

ArjenR commented 2 years ago

Hi Dave,

I had an issue to upgrade to the latest release for my existing install.

One issue is the non existence of defaultTimezone in the configuration file. The relevant commit adds this and extends the readme.

The other was at buildtime there is an issue with php throwing an error for missing ext-ldap. The quickest solution was to add the --ignore-platform-req=ext-ldap which was a proposed solution for the error message. I believe this is a temporary fix.

Kind regards, Arjen

tiredofit commented 2 years ago

Thanks for this. Can you refactor this a bit before I accept?

TIMEZONE is being handled by the up-up-upstream image (tiredofit/alpine) which hardcodes a Timezone variable right in the Dockerfile (Default Etc/UTC) so it can be removed from the "defaults" file.

Also, I think you may be able to get away with getting LDAP to work by right before the composer install command executing this helper php-ext enable core - That will preload the LDAP extension therefore bypassing the need to skip the check introduced. This was a weird development decision I did with the PHP-FPM image that sometimes needs to be done prior to building or installing dependencies.