tirr-c / jxl-oxide

Pure Rust implementation of JPEG XL decoder
Apache License 2.0
308 stars 13 forks source link

Isobmff-based containers unsupported #17

Closed gageberz closed 1 year ago

gageberz commented 1 year ago

Occurs when loading .jxl files that have isobmff-based containers. Does not occur with naked codestreams.

1.zip Code where it complains: let result = render .load_until_keyframe(bitstream, progressive, region) .expect("failed to load frames"); Error: thread '<unnamed>' panicked at 'failed to load frames: Frame(Bitstream(NonZeroPadding))', src/decoder/formats/jxl.rs:139:10

gageberz commented 1 year ago

If we don't panic at the error and let the program keep going, this is the result. t.txt

EugeneVert commented 1 year ago

Please check if you use jxl_bitstream::Bitstream::new_detect rather than jxl_bitstream::Bitstream::new, since the latter is used for bare codestream.

gageberz commented 1 year ago

I am using new_detect

gageberz commented 1 year ago

Apparently I fixed whatever the issue was since between now and when I opened the issue. Not sure what did it though.