search

tirthajyoti / Machine-Learning-with-Python

Practice and tutorial-style notebooks covering wide variety of machine learning techniques
https://machine-learning-with-python.readthedocs.io/en/latest/
BSD 2-Clause "Simplified" License
3.12k stars 1.8k forks source link

Wrong interpretation of the Shapiro-Wilk test #8

Open F-A opened 5 years ago

F-A commented 5 years ago

In the Regression_diagnostics notebook , you are presenting the Shapiro-Wilk test.

The Shapiro-Wilk test's null hypothesis is that the data come from a Gaussian distribution. Therefore, the lower the p-value, the higher the change to reject the Gaussian distribution. The notebook says the opposite: grafik

puddlejumper90 commented 3 years ago

Do you have a source article to reference? This might be good for those interested to study.

RRighart commented 3 years ago

Under "Encapsulation", cell 22 you have the line: self.fitted_ = np.dot(X,mlr.coef_) + mlr.intercept_

Where I think "mlr" should be replaced by "self": self.fitted_ = np.dot(X,self.coef_) + self.intercept_