search

tirumaraiselvan / graphql-engine

Blazing fast, instant realtime GraphQL APIs on Postgres with fine grained access control
https://hasura.io
Apache License 2.0
2 stars 0 forks source link

console changes for remote relationships #39

Closed wawhal closed 4 years ago

wawhal commented 5 years ago

Review app: https://hge-ci-pull-2240.herokuapp.com/console

wawhal commented 5 years ago

@rikinsk please add the code review here.

rikinsk-zz commented 5 years ago

@tirumaraiselvan the remote join isn't working with static value.

see: https://hge-ci-pull-2395.herokuapp.com/console/data/schema/public/tables/user/relationships and try query: 

{
  user {
    name
    country
    country_info {
      name
      code
    }
  }
}
tirumaraiselvan commented 5 years ago

Right. Apparently, empty [ ] for hasura join columns is buggy.

tirumaraiselvan commented 5 years ago

Let's keep this open for review. But lets not merge it. #2395 is the main PR now.