Closed jberryman closed 5 years ago
I have kind of ignored 2 functions: insertBatchResults
and extractRemoteRelArguments
for now. Will get to it after the pending comments are resolved.
Sorry I ran out of time/energy to think of a better name for RemoteRelBranch
. What does the "Ann" in RemoteRelAnnField
mean? For now I added a bit more explanation and a TODO
Sorry I ran out of time/energy to think of a better name for
RemoteRelBranch
. What does the "Ann" inRemoteRelAnnField
mean? For now I added a bit more explanation and a TODO
Ann
is just our internal abbreviation for annotation. It's fine. Let's do this later (if at all).
rebuildFieldStrippingRemoteRels
; there seemed to be some unnecessary and also insufficient filtering logic happening here (but could use a close review)enumerateRowAliases
,unEnumerateRowAliases
which we can document properlyextractRemoteRelArguments
and refactorcoerceSet
to Hasura.Prelude (this was used several times in a previous iteration, now only appears once; I'm not super committed to keeping it)