[ ] CHANGELOG.md is updated with user-facing content relevant to this PR.
Affected components
[ ] Server
[x] Console
[ ] CLI
[ ] Docs
[ ] Community Content
[ ] Build System
[ ] Tests
[ ] Other (list it)
Related Issues
4485
Solution and Design
Found remote_relationships is not having data with configuration instead it has the required values with the key definition. Observed that this data is coming from the server in this shape, hence not so sure if this will be a permanent refactoring or a conditional one.
In this situation made a handler that handles both the scenarios and makes sure that the UI renders error-free.
Steps to test and verify
Go to Console, open Remote schema.
Create a valid remote schema ( I used onegraph referring this)
Go to Hasura console
click on Data tab
Create a new data table.
click on Relationships tab.
Under Remote Relationships click on Add a new remote relationship button.
Choose the remote schema and create the remote schema relationship.
Click on the Save Button.
Current Behaviour
Remote schema relationship does not get created, it throws an error. as mentioned here #4485
Expected Behaviour
Remote schema relationship has to save successfully and it should be listed as shown below.
Limitations, known bugs & workarounds
If the key is permanently changed to definition then this extra check may not be required, also code pollution.
Server checklist
Catalog upgrade
Does this PR change Hasura Catalog version?
[*] No
[ ] Yes
[ ] Updated docs with SQL for downgrading the catalog
Metadata
Does this PR add a new Metadata feature?
[*] No
[ ] Yes
Does run_sql auto manages the new metadata through schema diffing?
[ ] Yes
[ ] Not required
Does run_sql auto manages the definitions of metadata on renaming?
[ ] Yes
[ ] Not required
Does export_metadata/replace_metadata supports the new metadata added?
[ ] Yes
[ ] Not required
GraphQL
[*] No new GraphQL schema is generated
[ ] New GraphQL schema is being generated:
[ ] New types and typenames are correlated
Breaking changes
[*] No Breaking changes
[ ] There are breaking changes:
Metadata API
Existing query types:
[ ] Modify args payload which is not backward compatible
[ ] Behavioural change of the API
[ ] Change in response JSON schema
[ ] Change in error code
GraphQL API
Schema Generation:
[ ] Change in any NamedType
[ ] Change in table field names
Schema Resolve:-
[ ] Change in treatment of null value for any input fields
Description
Changelog
CHANGELOG.md
is updated with user-facing content relevant to this PR.Affected components
Related Issues
4485
Solution and Design
Found remote_relationships is not having data with
configuration
instead it has the required values with the keydefinition
. Observed that this data is coming from the server in this shape, hence not so sure if this will be a permanent refactoring or a conditional one. In this situation made a handler that handles both the scenarios and makes sure that the UI renders error-free.Steps to test and verify
Remote schema
.Data
tabRelationships
tab.Remote Relationships
click onAdd a new remote relationship
button.Save
Button.Current Behaviour
Remote schema relationship does not get created, it throws an error. as mentioned here #4485
Expected Behaviour
Remote schema relationship has to save successfully and it should be listed as shown below.
Limitations, known bugs & workarounds
If the key is permanently changed to
definition
then this extra check may not be required, also code pollution.Server checklist
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
run_sql
auto manages the new metadata through schema diffing?run_sql
auto manages the definitions of metadata on renaming?export_metadata
/replace_metadata
supports the new metadata added?GraphQL
Breaking changes
[ ] There are breaking changes:
Metadata API
Existing
query
types:args
payload which is not backward compatibleJSON
schemaGraphQL API
Schema Generation:
NamedType
Schema Resolve:-
null
value for any input fieldsLogging
JSON
schema has changedtype
names have changed