search

tisfeng / Easydict

一个简洁优雅的词典翻译 macOS App。开箱即用，支持离线 OCR 识别，支持有道词典，🍎 苹果系统词典，🍎 苹果系统翻译，OpenAI，Gemini，DeepL，Google，Bing，腾讯，百度，阿里，小牛，彩云和火山翻译。A concise and elegant Dictionary and Translator macOS App for looking up words and translating text.
GNU General Public License v3.0
6.68k stars 338 forks source link

Add settings to shortcuts #416

Closed NeverAgain11 closed 5 months ago

NeverAgain11 commented 5 months ago

354

tisfeng commented 5 months ago

The highlighted state of this settings button looks a bit strange compared to the Eudic button next to it, and after clicking on "Go to Settings", this highlighted state does not disappear.

image
NeverAgain11 commented 5 months ago

Fixed problem with setting button. @Jerry23011 @AkaShark @tisfeng

Jerry23011 commented 5 months ago

The color of the Settings button doesn't seem to match the color of the Google button next to it, what do you think about changing the TintColor to light blue? Or another suitable color.

I would personally prefer to keep it grey. Since blue represents selected in the pin feature, it could be confusing to make the icon blue.

Also, for users who don't enable the other icons, the grey one looks more concise as it fits the accent colour of the app.

截屏2024-02-26 21 49 47
tisfeng commented 5 months ago

Sounds reasonable, what do the rest of you think about this?

phlpsong commented 5 months ago

I think grey is better.

AkaShark commented 5 months ago

Agreed it!

tisfeng commented 5 months ago

Ok, let's keep it grey.

tisfeng commented 5 months ago

Looks good.

tisfeng commented 5 months ago

Please continue to review.