Closed AkaShark closed 5 months ago
![Uploading CleanShot 2024-02-22 at 10.46.27@2x.png…]()
I found that the query service went missing after clearing text after a translation query
Let Me Look at it later
Do we need to place a close button to let users remove the tips cell manually?
Do we need to place a close button to let users remove the tips cell manually?
We don't need to add this close button, when the user query text isn't empty this tips view will not appear. In one query action, it will appear once
The previous issue was resolved.
I found that the frame at the bottom of the tips looks weird after starting to type in the query frame (please see screen recording below)
https://github.com/tisfeng/Easydict/assets/89069957/00f01be0-d8ed-4f39-87d1-592a81abacc8
@AkaShark Currently, in what cases does this tips view appear?
@AkaShark Currently, in what cases does this tips view appear?
When the query window is opened without any text in it, the tips view will appear. The tips view will disappear once the user enters their query text. After the tips view disappears, it will not appear again even if the user clears their query text. It means that the tips view will only appear once per query action.
I haven't looked at the code carefully yet, for PRs, I usually prefer to run the code first to see the effect.
Now, I still haven't triggered the display of the tips view, I don't know how to trigger it. I'm confused.
I haven't looked at the code carefully yet, for PRs, I usually prefer to run the code first to see the effect.
Now, I still haven't triggered the display of the tips view, I don't know how to trigger it. I'm confused.
Open EasyDict any window and query text is empty tips view will show, like this
Ok, let's continue review, I'll read the code carefully later.
We should clear tips view when clicking clear button.
I think we should add an option to allow users to turn off the display of the tips view.
Sometimes the tips view can be annoying if the user is fully aware of the FAQ.
okay I will perfect the above review on the weekend
I think we should add an option to allow users to turn off the display of the tips view.
Sometimes the tips view can be annoying if the user is fully aware of the FAQ.
I add a toggle for appear tips view in advance tab, so user can close tips view by manual.
最近频繁使用,这个功能误触发太多,我先 revert 了,稍后修复好再添加。
closed https://github.com/tisfeng/Easydict/issues/404