Fix tips view blank - Githubissues

tisfeng / Easydict

一个简洁优雅的词典翻译 macOS App。开箱即用，支持离线 OCR 识别，支持有道词典，🍎 苹果系统词典，🍎 苹果系统翻译，OpenAI，Gemini，DeepL，Google，Bing，腾讯，百度，阿里，小牛，彩云和火山翻译。A concise and elegant Dictionary and Translator macOS App for looking up words and translating text.

GNU General Public License v3.0

6.45k stars 328 forks source link

Fix tips view blank #499

Closed AkaShark closed 1 month ago

AkaShark commented 3 months ago

close https://github.com/tisfeng/Easydict/issues/452

tisfeng commented 3 months ago

When OCR succeeded, it also displays a tips view 🥲

There are other similar scenes, and tips view also appear strangely, and it doesn't necessarily appear every time.

AkaShark commented 3 months ago

There are other similar scenes, and tips view also appear strangely, and it doesn't necessarily appear every time.

emm.. OCR I didn't handle more, do you think merging the https://github.com/tisfeng/Easydict/issues/478 into this PR.

tisfeng commented 3 months ago

No, I know, there's no need to change the way tips are displayed when OCR fails at the moment, but it shouldn't be showing the tips view when OCR right now, whether it succeeds or fails.

What I mean is that the current way of determining when the tips view appears is inappropriate, it can easily be triggered by mistake, not only for OCR, but even for selecting translation I've encountered this several times, but it doesn't happen every time, it‘s strange.

AkaShark commented 2 months ago

Please help me continue review this code

tisfeng commented 2 months ago

你们看看这个 PR，我先准备一下发布新版本。