🐞 Bug Report: window arrangement been changed after query text

phlpsong commented 5 months ago

Please confirm the following:

[X] Be sure to check out FAQ
[X] I have carefully read the README
[X] I have searched through the issues page but couldn't find a solution.(Including issue that has been closed)
[X] Easydict has been upgraded to the latest version
[X] I understand and agree to the above, and understand that the project maintainer has limited energy, issues that do not follow the rules may be ignored or closed directly

Problem description

window arrangement been changed after query text

Is the issue consistently reproducible?

Reproducible

Steps to Reproduce

Open two Chrome(or any other app) window and one is focused
Open a window next to Chrome window
Query some content in Chrom
Back to Chrome

Screenshot

https://github.com/tisfeng/Easydict/assets/103433299/df5e475d-39ae-4e9c-a696-78b3302c30aa

Expected result

Not change window arrangement after back to the last frontmost app, current behavior is not proper in this case, I have to manually open the notes application after each query completed.

Proposed solution (optional)

Is it possible not to actively activate the previous window when closing the query window?

Device type and OS version

macOS 14.2.1

Are you willing to submit a PR to fix this issue?

[ ] I'm willing to submit a PR

tisfeng commented 5 months ago

I understand, indeed this could be a problem.

But this situation where one application has multiple windows is relatively rare, and should be acceptable for most users.

How should we fix it? Should we add an option to allow not automatically activating the previous application window?

phlpsong commented 5 months ago

I have compared Bob's behavior and found that its query window does not request to be focused, Chrom window has always been in focus, so they don't have such issue. Can we do the same?

tisfeng commented 5 months ago

No, I tried it and it automatically activates the previous frontend app as well.

I think this action is fine for the vast majority of users in most scenarios, especially when the user is typing in an input box, in this case hiding the Easydict window and then automatically activating the input box of the foreground application is useful, it makes it easy for the user to continue typing.

In some scenarios, activating the foreground application is necessary, for example, when using translated text to replace the original text.

https://github.com/tisfeng/Easydict/blob/e5ce53bc20ad6b34d04dff62a05fa2d6a361818c/Easydict/Feature/ViewController/View/CustomButton/EZReplaceTextButton/EZReplaceTextButton.m#L38

phlpsong commented 5 months ago

Well, let's leave things as they are for now. Maybe we can see how to improve later.

tisfeng commented 5 months ago

ok

tisfeng / Easydict