tisfeng / Easydict

一个简洁优雅的词典翻译 macOS App。开箱即用,支持离线 OCR 识别,支持有道词典,🍎 苹果系统词典,🍎 苹果系统翻译,OpenAI,Gemini,DeepL,Google,Bing,腾讯,百度,阿里,小牛,彩云和火山翻译。A concise and elegant Dictionary and Translator macOS App for looking up words and translating text.
GNU General Public License v3.0
7.03k stars 356 forks source link

fix: stop button was gone when querying stream service #514

Closed tisfeng closed 5 months ago

tisfeng commented 5 months ago

Fixed #510 , and

https://github.com/tisfeng/Easydict/assets/25194972/5a18a321-3e11-4501-85a2-e259c2d9b75b

tisfeng commented 5 months ago

截屏2024-04-18 08 17 36 It seems that Stop is not localized under Simplified Chinese when hovering over the stop streaming button

ok, fixed.

But this toolTip is not very useful at the moment, because the way streaming requests are displayed now is so bad that it will cause the UI to keep refreshing and the toolTip may not be visible.

In addition, the frequent refresh of streaming request will also lead to UI display bugs and high CPU usage, which I didn't consider when designed the program at the beginning, but it's hard to modify it at the moment, so we can only wait until later to rewrite it with SwiftUI directly 😥

Jerry23011 commented 5 months ago

looking forward to seeing the rewrite then

AkaShark commented 5 months ago

LGTM