tisfeng / Easydict

一个简洁优雅的词典翻译 macOS App。开箱即用,支持离线 OCR 识别,支持有道词典,🍎 苹果系统词典,🍎 苹果系统翻译,OpenAI,Gemini,DeepL,Google,Bing,腾讯,百度,阿里,小牛,彩云和火山翻译。A concise and elegant Dictionary and Translator macOS App for looking up words and translating text.
GNU General Public License v3.0
6.4k stars 325 forks source link

updating to 2.7 forces to change the app language to chinese and there's no way to change it back to english. #528

Closed hyperphysin closed 1 month ago

hyperphysin commented 2 months ago

Please confirm the following:

Problem description

updating to 2.7 forces to change the app language to chinese and there's no way to change it back to english.

Is the issue consistently reproducible?

Reproducible

Steps to Reproduce

just update it

Screenshot

Screenshot 2024-05-01 at 11 10 09 AM

Expected result

I want it to be in english!

Proposed solution (optional)

No response

Device type and OS version

apple m2 air, sonoma

Are you willing to submit a PR to fix this issue?

github-actions[bot] commented 2 months ago

Hello hyperphysin, Thank you for your first issue contribution 🎉

tisfeng commented 2 months ago

Please try to change app language manually.

image
tisfeng commented 2 months ago

@choykarl If you have time, please take a look at this issue and see if it modifies the user's App language?

thesla13 commented 2 months ago

Hey, @tisfeng! I have the same issue @choykarl does.

The thing is the settings page looks nothing like the one in your screenshot. It never did look that way for me in previous versions either. It always looked like this:

snap 2024 05 01 07-06-25

And there doesn't seem to be an option to change the interface language. In your screenshot it's directly above the appearance setting, while there is nothing above the "外观" setting in the layout I happen to have.

I am very much confused, honestly ((

tisfeng commented 2 months ago

We rewrote the settings page using SwiftUI and added many new features, such as app language switching, but this part of SwiftUI functionality requires macOS 13.0+.

If your computer system is macOS 13.0+, the settings page will have the SwiftUI App option. Please enable it and then restart Easydict.

image
Diane-Best commented 2 months ago

image 下载最新版2。7.0安装时 报错

tisfeng commented 2 months ago

最近我们并没有更改相关的代码,可能是苹果的安全认证又变严格了 🫠

请尝试:设置-隐私与安全性-仍要打开 Easydict

image
thesla13 commented 2 months ago

Hey, @tisfeng! Thanks for the reply!

I've switched to the SwiftUI version, it launched in Chinese, but the settings pane became just like in your screenshot, the language switch was right there, and everything is quite perfect now. Thank you!

Except for one minor thing. I use AltTab window switcher instead of macOS' built-in one. It mimics the way window switching works in Windows listing all the apps' windows instead of switching between apps. And while there is nothing unusual to be seen in Mission Control, AltTab's window switching pane shows a stray faceless window called "Go to Settings" and carrying EasyDict's icon. It's there whenever ED is running: I quit it — the window goes away; launch it again — it reappears.

snap 2024 05 02 04-19-18 snap 2024 05 02 04-22-21

Could you please look into this?

Thank you so much for your hard work!

tisfeng commented 2 months ago

@thesla13 We've fixed the language issue https://github.com/tisfeng/Easydict/pull/530 .

I'm not using AltTab, we'll check on this issue later.

thesla13 commented 2 months ago

@tisfeng

I've looked a bit closer, and it's not just AltTab. The stray interface-less Easydict window is there in Mission Control as well. Admittedly, you have to look for it, but it is there, and for no good reason.

snap 2024 05 03 02-31-20 snap 2024 05 03 02-02-19

tisfeng commented 2 months ago

Thanks for your feedback, I checked the code and it is indeed a bug, we will fix it later.

tisfeng commented 2 months ago

The problem is probably caused by this code.

@AkaShark Could you take a look at it?

https://github.com/tisfeng/Easydict/blob/d6d04b19d9906fb90b1cd0b71cec6f6cdd496dd1/Easydict/App/EasydictApp.swift#L59

AkaShark commented 2 months ago

The problem is probably caused by this code.该问题可能是由这段代码引起的。

@AkaShark Could you take a look at it? 你能看一下吗?

https://github.com/tisfeng/Easydict/blob/d6d04b19d9906fb90b1cd0b71cec6f6cdd496dd1/Easydict/App/EasydictApp.swift#L59

Sure, I'll check the code later.

tisfeng commented 1 month ago

This issue has been fixed in version 2.7.2.