tisfeng / Easydict

一个简洁优雅的词典翻译 macOS App。开箱即用,支持离线 OCR 识别,支持有道词典,🍎 苹果系统词典,🍎 苹果系统翻译,OpenAI,Gemini,DeepL,Google,Bing,腾讯,百度,阿里,小牛,彩云和火山翻译。A concise and elegant Dictionary and Translator macOS App for looking up words and translating text.
GNU General Public License v3.0
6.38k stars 324 forks source link

pref: remove main storyboard & EasydictHelper #576

Closed AkaShark closed 4 weeks ago

AkaShark commented 1 month ago

closed https://github.com/tisfeng/Easydict/issues/553#issuecomment-2110588570

AkaShark commented 1 month ago

CleanShot 2024-06-03 at 22 04 43@2x

I don't know what EastdictHelper is for our project, can I delete it, and delete the entire target as well

Jerry23011 commented 1 month ago

I don't know what EastdictHelper is for our project

I think it's for launch at login?

AkaShark commented 1 month ago

I don't know what EastdictHelper is for our project

I think it's for launch at login?

I am not sure, but I have not encountered some of it in the build settings. I do not have much experience in developing for Mac OS.

Jerry23011 commented 1 month ago

Not sure either, I think that's what's it's saying in AppDelegate? https://github.com/tisfeng/Easydict/blob/381033d4d27cf95a398ee1c608e33137a9003090/EasydictHelper/AppDelegate.m

tisfeng commented 1 month ago

The code related to EastdictHelper can now be deleted.

EastdictHelper was initially intended to enable the application to start on boot, but users reported that it was ineffective, as seen in this issue: https://github.com/tisfeng/Easydict/issues/64.

I attempted to use SMAppService, but it didn't work out, so I ultimately used AppleScript to implement it.

https://github.com/tisfeng/Easydict/blob/381033d4d27cf95a398ee1c608e33137a9003090/Easydict/objc/Configuration/EZConfiguration.m#L523

AkaShark commented 1 month ago

SMAppService

OK I will remove the EasydictHelper, I found the commit you said https://github.com/tisfeng/Easydict/commit/f49652f592d33d47a79f7a405e86e9d0aa53be58