tisho / sketch-plugins

A collection of plugins for Bohemian Coding's Sketch.
645 stars 25 forks source link

Activating the Plugin Does Nothing #3

Open philipamour opened 10 years ago

philipamour commented 10 years ago

Performed same steps as in #2 ; however, the result is this case is a bit different - nothing happens. Sketch lags for a second and nothing happens. Again - the plugin works flawlessly on a fresh new document with randomly created layers.

Maybe this issue occurs because of how we use Sketch - we have got multiple pages (around 10) and multiple art boards on each. Perhaps the plugin (or Sketch) cannot handle big files like that.

tisho commented 10 years ago

I've tested the plugin on larger files (with multiple pages/artboards) and while performance is degraded, it definitely should still work.

There's no way for me to tell what's going on without taking a look at the file you're testing on. If you're not comfortable with sharing (I totally understand), I'll spend some time working on a debug version of the plugin that we could use to diagnose this. Should be done with it later today or tomorrow, so stay tuned.

rojcyk commented 10 years ago

It does nothing for me too. Even on freshly created document. I made sure I am doing everything right. The plugin is installed for Sketch & Sketch Beta. I've tried both with no success :(

Latest updates for Sketch as well as Mavericks. (10.9.1)

tisho commented 10 years ago

@rojcyk: Can you share the document you're testing with? It would be very helpful.

RaphyRaph commented 10 years ago

I have the same problem, it mostly doesnt work for me. I've only gotten it to work once. Here's the fresh file that I'm using. http://cl.ly/2F0z3A2m3I3l

tisho commented 10 years ago

@RaphyRaph, I just tried it on your file and it worked fine on my end. Do you see the "Sync Symbol" entry under the plugins menu? Also, what version of Sketch do you have?

RaphyRaph commented 10 years ago

@tisho I have the latest beta version, and yes I have the sync plugin installed :smile:

I'm guessing you don't support the beta. Usually the beta is just much more advanced than stable release, fixes quite a number of bugs, and is used by a good chunk of the Sketch community, specially people in the tinkering/plugin scene. The Bohemian Coding guys did not release anything for a while, so I'm guessing they're working on a big release, so the current beta should hold for a while.

tisho commented 10 years ago

The plugin works fine in the beta (I'm using the beta to test it myself). Is it possible to record a short screencast of exactly how you're working with the file you attached? Everything works fine for me, so I'm wondering why it wouldn't for you.

RaphyRaph commented 10 years ago

http://youtu.be/PyeK1LBeX5o

tisho commented 10 years ago

Ah, I see now. Thanks so much for going the trouble to do the screencast.

The problem is that you don't have a symbol or its sublayer selected when you press Cmd+E. Symbol in "Sync Symbol" is singular on purpose :) The plugin won't try to discover all symbols in the document and sync them all. This is because there's no way for the plugin to tell which copy of the symbol you consider the "source of truth". By selecting a symbol and then activating the plugin, you're basically telling it "consider the symbol I've selected the source of truth and replicate its styles/layers across other copies of the symbol."

TLDR: you shouldn't have clicked on an empty spot to clear the selection after you moved one of the circles. While you still have the layer/symbol selected, press Cmd+E (you actually do that around the 1:05 mark and it works).

Hope this clears it up.

RaphyRaph commented 10 years ago

Thanks! That makes total sense. I think you should make it clearer in the explanation (and not a lot f people read documentation, :smiley: ), cause it looks like some people are having the same problem.

tisho commented 10 years ago

I will. Thanks for the suggestion!