tisimst / pyDOE

Design of experiments for Python
BSD 3-Clause "New" or "Revised" License
263 stars 114 forks source link

_lhscorrelate calculates correlation coefficient incorrectly #29

Open rob5ives opened 3 years ago

rob5ives commented 3 years ago

The correlation coefficient in _lhscorrelate is calculated as: R = np.corrcoef(Hcandidate) According to NumPy documentation, this function expects each row to be a variable; however, lhs treats the columns as variables. The correct way to calculate the correlation coefficient should be: R = np.corrcoef(Hcandidate, rowvar=False)