tisoap / react-flow-smart-edge

Custom Edge for React Flow that never intersects with other nodes
https://tisoap.github.io/react-flow-smart-edge/
MIT License
256 stars 35 forks source link

Connection line appears broken when using specific grid snapping #45

Open DraksBG opened 1 year ago

DraksBG commented 1 year ago

Describe the Bug

Is your feature request related to a problem? Please describe. Hello @tisoap we are having the following situation when using SmartEdge with GridSnapping

we are having custome grid snaping position and when we connect a parent node to three child nodes at some point the connection gets broken and it's not always a straight line.

My question is, is there a way always to be sure to make the connection straight when using StepEdge, can you suggest a fix if you have ever come across such a problem.

The code for what we use is as follows for the gird snapping and smartEdge:

export const snapGridValue: SnapGridValueProps = { snapGrid: [90, 60], snapToGrid: true, backgroundGap: [90, 60], sizeCrossDots: 40, backgroundGridColor: '#e1e1e1', }

const getSmartEdgeResponse = getSmartEdge({ sourcePosition, targetPosition, sourceX, sourceY, targetX, targetY, nodes: updatedNodes, options: { drawEdge: svgDrawStraightLinePath, generatePath: pathfindingJumpPointNoDiagonal, }, })

Minimal Example

https://codesandbox.io/s/trusting-rubin-nus8rh

Steps to Reproduce the Bug or Issue

Add three nodes Connect them to the parent node and spred them one to another and observe the behavior of the connection line.

Expected behavior

Connection line should be straight after the first step edge

Screenshots or Videos

image image-2022-12-01-08-52-49-896

Platform

Additional context

No response

antipasvasil commented 1 year ago

Hi, @tisoap is there will be any solution/s of the reported problem...