search

tispratik / bs

BS
1 stars 0 forks source link

Sergey - Project Roles Page. #19

Closed TheHumaneClub closed 14 years ago

TheHumaneClub commented 14 years ago

Replace the drop down owner / collaborator and button 'Update Role' by one button which runs by logic

  1. If collaborator then display button Make Owner.
  2. If owner then display button Make Collaborator

Another functionality I started working on:

  1. Reinvite => Resends email to an already invited person
  2. Revoke Invitation => Revokes an invitation from an already invited person
svarks commented 14 years ago

added remove and resend invitation links for pending invitations.

TheHumaneClub commented 14 years ago

Cool now "Revoke Invitation" remaining thats it.

svarks commented 14 years ago

But it's not the same as remove invitation?

TheHumaneClub commented 14 years ago

Ya same remove invitation, but we need remove link out there right? For an invited person there is no remove link

svarks commented 14 years ago

why? you can just remove role

TheHumaneClub commented 14 years ago

May be i dint take latest code :) .. lemme re download

TheHumaneClub commented 14 years ago

Ok now I see.

  1. Remove %h2 Pending Invitations... I want both tables to look seamless.
  2. Why this? - unless invitation.user .... we should be able to reinvite even if invitation doesnt have user, right? We have his email id, so we can reinvite?
  3. Convert remove to image = link_to image_tag('delete.png')
svarks commented 14 years ago
  1. ok. ill remove
  2. now we send emails only for users who aren't registered yet 3 . ok
TheHumaneClub commented 14 years ago

1,3 ok 2 i think we should send for everyone. what if a user is registered but isnt accessing account for long. if project manager x decides to invite him into his project, he needs to be notified via email

svarks commented 14 years ago

ok sending to all users now

TheHumaneClub commented 14 years ago

done