tisztamo / Junior

AI-First IDE which fully codes itself: No code was written by humans here.
https://aijunior.dev
MIT License
22 stars 7 forks source link

Fix a place where invalid input terminates the server #25

Closed tisztamo closed 1 year ago

tisztamo commented 1 year ago

Project Description

Hey, Contributor!

Interpret issues freely. Need help or have ideas? Comment right here. Remember, this is the only forum where Krisztián answers questions - your golden ticket to help!

Keep it friendly, that's our vibe.

Happy contributing!

DarshanDixit05 commented 1 year ago

Hey @tisztamo, I really want to know the exact meaning of "place" in the issue. Validating input and terminating the server is what I got. Can you please describe the issue briefly? Or the steps to recreate it ?

tisztamo commented 1 year ago

Hi @DarshanDixit05!

Thanks for asking, this really needs clarification!

A place I know about is the shebang check in src/execute/executeAndForwardOutput.js

The error should be catched in the corresponding handler and directed to the frontend instead of terminating the server. A console.log on the frontend (and on the backend) would be great for now.

DarshanDixit05 commented 1 year ago

The error is now cached in the catch block and getting logged in the console. Please have a look at the picture. Let me know if its ok.

Screenshot 2023-07-29 212151
tisztamo commented 1 year ago

Great, definitelly a solution to the original problem! Send a PR, please!

DarshanDixit05 commented 1 year ago

Sure, I raised one.

tisztamo commented 1 year ago

28 Closes this