Closed mascarenhas closed 6 years ago
BTW, I ended up making this dependent on PR #178, but as this is not critical it is ok to only merge this after that PR commits are in master.
Merging #181 into master will increase coverage by
<.01%
. The diff coverage is97.82%
.
Impacted Files | Coverage Δ | |
---|---|---|
titan-compiler/coder.lua | 96.73% <100%> (ø) |
:arrow_up: |
titan-compiler/driver.lua | 74.22% <100%> (+0.26%) |
:arrow_up: |
titan-compiler/checker.lua | 94.06% <88.88%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 602c903...638d165. Read the comment docs.
I would prefer to continue calling the compiler titanc. Iirc, we decided to name it like that to be more consistent with other programming languages
also, eventually I'd like to have a titan
catch-all command that drives titanc
and does more things, like go
(titan fmt
, titan get
, etc.)
I went ahead and merged this without the titanc
-> titan
rename (learning to be more "agile" :laughing: ), this is a fix worth having now (was already biting me in foreign
) -- we can revisit the executable name issue later!
The
driver.compile
function was not taking into account dots in the module name, sotitanc
was generating files with wrong names. Also renamedtitanc
totitan
, to reflect the change in the help text for it.