titan-lang / titan

The Titan programming language
http://titan-lang.org
MIT License
406 stars 13 forks source link

[master] remove troublesome global C state from modules #235

Closed hishamhm closed 6 years ago

hishamhm commented 6 years ago

This is a rebase into master of PR #233.

codecov-io commented 6 years ago

Codecov Report

Merging #235 into master will increase coverage by 0.14%. The diff coverage is 99.15%.

Impacted Files Coverage Δ
titan-compiler/types.lua 86.71% <100%> (+0.3%) :arrow_up:
titan-compiler/checker.lua 89.83% <100%> (+0.47%) :arrow_up:
titan-compiler/coder.lua 96.37% <99.1%> (-0.09%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1909351...02e7e4f. Read the comment docs.

hishamhm commented 6 years ago

@mascarenhas this made it much easier to follow! (and made me note that there was an update done to codearray that wasn't done in codemap; I updated and squashed it there — I'll probably refactor the common parts of these functions later)

hishamhm commented 6 years ago

I would prefer to merge this one instead (and work using this version over the weekend, until we get a chance to discuss primitives in the next meeting)

mascarenhas commented 6 years ago

I am fixing a couple of loose ends and will push a commit soon, and then we can merge.

mascarenhas commented 6 years ago

My commit addresses two issues:

mascarenhas commented 6 years ago

Feel free to merge this into master!