Closed hishamhm closed 6 years ago
Merging #235 into master will increase coverage by
0.14%
. The diff coverage is99.15%
.
Impacted Files | Coverage Δ | |
---|---|---|
titan-compiler/types.lua | 86.71% <100%> (+0.3%) |
:arrow_up: |
titan-compiler/checker.lua | 89.83% <100%> (+0.47%) |
:arrow_up: |
titan-compiler/coder.lua | 96.37% <99.1%> (-0.09%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1909351...02e7e4f. Read the comment docs.
@mascarenhas this made it much easier to follow! (and made me note that there was an update done to codearray
that wasn't done in codemap
; I updated and squashed it there — I'll probably refactor the common parts of these functions later)
I would prefer to merge this one instead (and work using this version over the weekend, until we get a chance to discuss primitives in the next meeting)
I am fixing a couple of loose ends and will push a commit soon, and then we can merge.
My commit addresses two issues:
value
s in the primitives
branch that we should keepFeel free to merge this into master
!
This is a rebase into
master
of PR #233.