search

titanscouting / red-alliance-mobile

Red Alliance App in React
2 stars 6 forks source link

Remove frequent sign-in prompts #202

Closed funblaster22 closed 1 year ago

funblaster22 commented 1 year ago

fixes issue #198

To me, it looks like the line I deleted was unnecessary because if GoogleSignin.getCurrentUser() fails, it would call GoogleSignin.signIn() anyways. This will make development a lot less annoying because it asks me to sign in every time I reload the app, it shows the prompt, but signing in in those instances is redundant because if I tap outside the focused area, the app will resume as normal.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

devksingh4 commented 1 year ago

The sign-in prompts are done over and over again because the tokens don't seem to refresh correctly after 90 minutes unless you do. If you can demonstrate that the tokens work correctly then I'll take another look.