titansgroup / k4l-video-trimmer

A library with UI and mechanisms to trim local videos on Android applications.
MIT License
784 stars 221 forks source link

Error in selecting range with large files. #59

Closed anubhavmalik closed 5 years ago

anubhavmalik commented 5 years ago
Include the following:
Reproduction Steps
  1. SetMaxDuration as 30 seconds
  2. Choose a large sized video. Say 2 hours (A movie or something)
  3. Move the range seek bar to ends of the movie, the max duration will increase and not remain 30 seconds (visually).
Expected Result

A trimmed file of 30 seconds duration

Actual Result

A trimmed file of 2 - 3 minutes

Tell us what could be improved:

anubhavmalik commented 5 years ago

I have fixed the issue and forced the duration at setMax length. Will probably create a PR sometime in the future.

aashitshah26 commented 3 years ago

Hey what changes have you done ?