search

titarenko / OAuth2

OAuth2 client implementation for .NET
412 stars 154 forks source link

Example config for .net core #133

Open TheDevelolper opened 4 years ago

TheDevelolper commented 4 years ago

Your examples in the readme are outdated.

Can you please provide an example of a appsettings.json config for .netcore?

niemyjski commented 4 years ago

Would you mind creating an example and updating the readme.

TheDevelolper commented 4 years ago

@niemyjski I would love to help but unfortunately I require the config because I can't get it working.

TheDevelolper commented 4 years ago

I will take a second look at your solution I mean that be able to figure it out from there. If I do I will update it.

It would be a lot easier if you could do it though as you know the project infinitely better than I.

TheDevelolper commented 4 years ago

Nope sorry... I've given up with this library... the documentation is out of date.

niemyjski commented 4 years ago

We're all developers here and this is an open source project... I don't have time right now or anytime in the immediate future to update this readme. Your help would be greatly appreciated.

TheDevelolper commented 4 years ago

I feel like a stuck record here... As I said I can't figure it out because your docs are out of date.

If you don't want to maintain your own readme then don't worry about it. Just close the ticket.

niemyjski commented 4 years ago

I'll try and update it, it's just a really long list on many projects and I don't use this project in that way... I drive it via code and not configuration which is mostly why it's not documented. I try my best to help the community, but I would love if sometimes the developer community would give back as well. I get things might not always be easy but it's a great way to dig in, learn the library and give back.

niemyjski commented 4 years ago

With that said, my apologies I came across negatively. It would be nice to get some help :-). I did dig into this just now, it looks like we (probably I), removed the ability to read and populate providers from configuration when we moved to .NET Core as it wasn't supported via the configuration manager. There looks like there is still an old and unused xml settings file here: https://github.com/titarenko/OAuth2/blob/master/OAuth2.Tests/App.config but that won't work as nothings looking at it. Looks like we'd need to build something to read from the IOptions or maybe just have a model that resembles the configuration we need and then load that from app settings via IOptions... I haven't really done this before but I'd be more than happy to point you in the right direction. Would you mind taking a stab at this? I'm curious to why you need this to be configuration based vs hard coded (Providers don't change much so seems like adding or removing one should require code change?)? Just let me know I'll do my best to get you up and running.

TheDevelolper commented 4 years ago

No you didn't come across negatively at all. I was just desperately trying to get this working. I apologise that my frustration surfaced in my message.

I thought it needed to be config based as (from the top of my head) what I was doing required an IConfigSection in your code.

I can't quite remember exactly what it was now. I opted to do it manually from scratch.

Eventually I gave up my project completely as LinkedIn don't allow you to send messages unless you're a marketing partner. 🤦‍♂️

I wanted to be able to alert clients that subscribe when I'm available for work and when I've found work too.

But I think I may have to opt for email.

If I get time I will try and take a look at it but I've also got a lot on my plate at the moment. I have tried already a couple of times with no luck.

armw4 commented 3 years ago

Yah - it's definitely not easy to maintain a project without additional support. Yes f course everything falls on the core maintainers but eventually it's not fair when we're all benefiting. I applaud the React.js deca for soliciting the involvement of others even when they knew for sure they could be the ones resolving issues. Same team same dream fellas.