search

titicaca / spark-iforest

Isolation Forest on Spark
Apache License 2.0
226 stars 90 forks source link

Bug: switch position #2

Closed luzengxiang closed 6 years ago

luzengxiang commented 6 years ago

Could you check this paragraph of code, it seems incorrect.

// select randomly a feature index attrIndex = constantFeatures(rng.nextInt(numFeatures - constantFeatureIndex) + constantFeatureIndex) val features = Array.tabulate(data.length)( i => data(i)(attrIndex)) attrMin = features.min attrMax = features.max if (attrMin == attrMax) { // swap constant feature index with non-constant feature index val tmp = constantFeatures(attrIndex) constantFeatures(constantFeatureIndex) = tmp constantFeatures(attrIndex) = constantFeatures(constantFeatureIndex)

titicaca commented 6 years ago

Fixed. Thanks for reporting it.