titicacadev / triple-frontend

Monorepo for Triple Frontend Components and Libraries
https://storybook.triple-corp.com
MIT License
137 stars 9 forks source link

FlickingCarousel을 원상복구 #3359

Closed drakang4 closed 2 weeks ago

drakang4 commented 4 weeks ago

PR 설명

FlickingCarousel을 원상복구

변경 내역

FlickingCarousel (기존 carousel 패키지)를 원상 복구 합니다. FlickingCarousel이 userAgent context에 의존성이 있기 때문에 tds-widget으로 옮깁니다. poi-detail / recommended-articles 디자인을 복구합니다. 스토리북 decorator에 ua-parser-js를 추가해서 실 사용자의 userAgent를 사용합니다.

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 14.50%. Comparing base (57a0b0b) to head (f040bb0). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...widget/src/flicking-carousel/flicking-carousel.tsx 0.00% 24 Missing and 3 partials :warning:
...tail/recommended-articles/recommended-articles.tsx 0.00% 3 Missing :warning:
...es/tds-widget/src/flicking-carousel/arrow-icon.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3359 +/- ## ========================================== - Coverage 14.76% 14.50% -0.27% ========================================== Files 721 717 -4 Lines 10106 10061 -45 Branches 3314 3313 -1 ========================================== - Hits 1492 1459 -33 + Misses 8189 8175 -14 - Partials 425 427 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

drakang4 commented 3 weeks ago

@seulgiyoon 추가했습니다