search

titilambert / pyhydroquebec

DEPRECATED - Get your consumption data from your HydroQuebec account (www.hydroquebec.com)
Apache License 2.0
94 stars 44 forks source link

Docker MQTT deployment #48

Open diogos88 opened 4 years ago

diogos88 commented 4 years ago

Modified your project to deploy with docker-compose and fix the configuration implementation (mqtt).

diogos88 commented 4 years ago

Thanks for the review,

Why you changed the dockerfile I modified the dockerfile to integrate the mqtt portion and the persistence of the config file. With mqtt added in the dockerfile, it will simplify users integration in their environment and domotic application.

Why you changed the mqtt push data This part was modified to only have one topic per account/contract_id. Correct me if I am wrong but the balance topic should be in the contract_id topic.

Why using docker-compose, when there is only one container ... a single docker command can do the trick I use docker-compose because it's easier to read and structure, that's the only reason. At the end it's the same thing as a docker run command.

titilambert commented 4 years ago

Thanks for your answers !!

Why you changed the dockerfile I modified the dockerfile to integrate the mqtt portion and the persistence of the config file. With mqtt added in the dockerfile, it will simplify users integration in their environment and domotic application.

I'm sorry but I still don't understand those changes in the Dockerfile. Today, I'm using the current master docker image with MQTT without any issue. What are the issues that you're a trying to solve with theses change ?

Why you changed the mqtt push data This part was modified to only have one topic per account/contract_id. Correct me if I am wrong but the balance topic should be in the contract_id topic.

Thanks for this one !

Why using docker-compose, when there is only one container ... a single docker command can do the trick I use docker-compose because it's easier to read and structure, that's the only reason. At the end it's the same thing as a docker run command.

OK, Thanks for this one too !

titilambert commented 4 years ago

BTW, I will handle the merge conflict (I created it ...)