SS4 Upgrade **** WORK IN PROGRESS ****

[gordonbanderson]

hi,

I have this apparently working with SilverStripe 4, but I am a little unsure of all the intended functionality due to the lack of documentation. For example I have no idea what a shaded calendar is, and there are contradictory references to private events being possible or not possible. As such could you have a look at this attempt and see if anything is awry?

Cheers

Gordon

[anselmdk]

This looks good, Gordon, much appreciated. This is much code, and I'm not currently on SilverStripe 4, but I'll be very happy to merge. The only thing I'm asking is for you to updat the "compatibility" section of the README to reflect that master will now be SilverStripe 4 only: https://github.com/titledk/silverstripe-calendar#compatibility

[gordonbanderson]

Noted re compatibility - though I had issues getting it working reliably in 3.x when testing ;) I am still finding bugs so hold off on merging for now, Given lack of unit tests (though I have set up continuous integration now), I guess a test of this code would be to have a working demo somewhere. I will create a suitable silverstripe theme composer package after I've finished my current project for this purpose.

Cheers

G

[anselmdk]

Did you ever try this one: http://calendar.demo.title.dk - the source code is here: https://github.com/titledk/silverstripe-calendar-demo

Anyway, that's a little old. I'll hold off merging until you give me the go!

[terryapodaca]

@gordonbanderson just curious what the current status of this is. I haven't seen anyone comment on merging this or starting a new branch for SS4. Do you have this in a working version for SS4 that is downloadable or install-able via composer?

[chriszuercher]

I'm also intrested to know the state of this PR. Wouldn't it make sense to create a branch out of it?

[terryapodaca]

@chriszuercher I don't know how to make a branch out of it...but if someone can and make it installable via Composer that would be great! I don't even know how to view this versions code!!!

[terryapodaca]

How can I get my hands on this code?

[gordonbanderson]

hi,

Apologies for the slow response but my focus is not on programming at the moment. Unfortunately my father passed away recently and I am helping mum transition into the next stage of her life, and have effectively become the DIY guy and gardener for now.

You can install this module with composer as follows:

1) Add the git version control repository to composer.json

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/gordonbanderson/silverstripe-calendar.git"
        },

2) You can then do

composer require "titledk/silverstripe-calendar" "dev-upgradess4"

It works but I've only installed it on one site, and it feels rough around the edges. There is a lack of unit testing, something I've not had time to add, and I think this module needs it as it's somewhat complicated. I was also having to guess some of the functionality as per the original post of this PR.

The 3.x version of the module had a lot of configuration options (too many, and like the comments module it can lead to unnecessary complexity), checking the server install I'm running with the default configuration as per the module.

Regards

Gordon

[gordonbanderson]

There is a bootstrap 4 compatible theme here https://github.com/gordonbanderson/silverstripe-events-theme, but I've not tested it in isolation, as I overrode some templates with the client theme. If either of you wish to open PRs againt these branches I will try and be more diligent in my GitHub notification watching, I am normally at my computer in the evenings UK time.

[terryapodaca]

@gordonbanderson I've followed your steps and cannot get this to install on a SS4.2 installation. Any tips? I've followed your instructions to the T and nada...still spits out that something in the module is looking for the old framework, not the recipe.

[gordonbanderson]

What exactly was the problem you got?

There is an error above, the JSON should be

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/gordonbanderson/silverstripe-calendar.git"
        }
],

(the closure of the array was missing).

It's installing but erroring out when I try to add an event, looking into it

[terryapodaca]

@gordonbanderson I finally got this installed. Thanks for your help. A couple minor issues I have noticed.

1. The LeftandMain icon shows a Circle Star and not the Calendar icon. I think my client would benefit from seeing the calendar icon even though it says "Calendar" next to the icon, but when that section goes small they might not understand or remember that the circle-star is the Calendar because the text gets hidden.

2. What are the new "Configurations" we need to set up? Do we set them up in _config.php still or in a .yml file? I ask if there are new/updates settings or configurations because I can't see some options in creating a new calendar, like colors, etc.

[terryapodaca]

I've been able to successfully get everything working in the CMS, but nothing, and I mean nothing, loads on the front end. Any thoughts?