Updating contributors - Githubissues

titoBouzout / WordCount

Real-time Word, Char, Line and Page counter, in the status-bar for the document, line or selection. Sublime Text

Other

291 stars 50 forks source link

Updating contributors #22

Closed proappsteam closed 11 years ago

proappsteam commented 11 years ago

Having contributed so far:

Pointing out the incompleteness in dealing with tab separation in issue #16, proposing a pull #20 to generalize for all white-space characters. The pull is merged into the st3 branch.
Proposing a pull and working with the pull #19 to update the regular expression in capturing sentences.

titoBouzout commented 11 years ago

It would be nice if you can check the log also to see if we miss some other contributor. PS: wrong branch, it should be st3

proappsteam commented 11 years ago

I did some research and have added 3 more contributors + the links to the authors also. PS: The incompleteness exists in the master branch also, right? So the contribution is one way or another affects the master branch, isn't it?

jbrooksuk commented 11 years ago

The master branch is for ST2.

proappsteam commented 11 years ago

Well I see. But the contributors I listed in the last commit have contributed in this plugin in general :)

titoBouzout commented 11 years ago

OK, update contributors but on st3 branch. Thanks harryngh

jbrooksuk commented 11 years ago

@titoBouzout are you okay with the advertisement?

proappsteam commented 11 years ago

Thank you too.

titoBouzout commented 11 years ago

Is not OK, we have a experience here of a user that tried hard to put a link in our readme.md for SEO purposes.

Since the main intention of the contribution was to get the link, and not to improve the package, the suggestions were done without thinking to much, even going to incorrect paths of updating the master branch for contributions done in an unrelated branch: ST3. All of this taking and consuming some of the people time...

May entertainment for some, but frustrating, It finally got the point of doing an actual contribution, and I have no problem with putting links near to contributor names per request or suggestion..

jbrooksuk commented 11 years ago

Ok then :+1: