search

titouancreach / vuejs-redux

Flexible binding between Vue and Redux
57 stars 11 forks source link

Add prettier #29

Closed titouancreach closed 6 years ago

titouancreach commented 6 years ago

That would be cool if we add a prettierrc file, add a command to format in the package.json, and add prettier in the dev dependencies

khrystuk commented 6 years ago

Hey @titouancreach! I would like to work on it

titouancreach commented 6 years ago

No problem, go ahead. Thanks a lot! 😊

titouancreach commented 6 years ago

No problem, go ahead. Thanks a lot! 😊

titouancreach commented 6 years ago

There is some rule I like in the prettier rc, no semicolumn, single quote, es5trailing commas, and no space in bracket spacing 😀

khrystuk commented 6 years ago

Done in #30.

titouancreach commented 6 years ago

Wow nice! Maybe we should ignore the bundle.js?

titouancreach commented 6 years ago

Or all the dist directory?

khrystuk commented 6 years ago

@titouancreach Added .prettierignore

titouancreach commented 6 years ago

Awesome, lgtm, I merge this asap, thanks again! :relaxed:

vvscode commented 6 years ago

Also added lint-staged configuration https://github.com/titouancreach/vuejs-redux/pull/32/files

titouancreach commented 6 years ago

thanks @vvscode !