search

titouancreach / vuejs-redux

Flexible binding between Vue and Redux
57 stars 11 forks source link

Add integration with CI ( like TravisCI ) to run tests on PR #33

Closed vvscode closed 6 years ago

vvscode commented 6 years ago

It would be great add CircleCI / TravisCI or something similar to check code on PR

titouancreach commented 6 years ago

I totally agree! I've never done this before, could you make a PR ?

vvscode commented 6 years ago

@titouancreach I'll do, but after merging you need autorize on Travis CI and enable integration with repo ( that should be done by repo owner )

titouancreach commented 6 years ago

no problem :)

titouancreach commented 6 years ago

Should we consider that if npm run test and npm run build run without error, it's ok ? Maybe we should add something that check the code style (since @khrystuk added prettier) we could run npm run prettier --list-different

vvscode commented 6 years ago

ok

titouancreach commented 6 years ago

This is working very well, thanks again :)