titu1994 / DenseNet

DenseNet implementation in Keras
MIT License
707 stars 294 forks source link

should input not be concatenated? #27

Closed ahundt closed 7 years ago

ahundt commented 7 years ago

Also, looking at several implementations and network diagrams, such as this: denseblock

It appears that in __denseblock needs to be modified a bit because the input is only connected to the output through conv blocks.

x_list = [x]

should be:

x_list = []

which should mean the relevant instances of [1:] in the file can go away. I also think this also means concat_list does not need to be returned.

the same should apply for keras-contrib

titu1994 commented 7 years ago

It's fine. This is more clear in what it is doing. By stating explicitly that the input is added to the list and not used in concatenate is in line with what the paper wrote, so for clarity I wrote it that way as well.

Makes no difference in performance.