search

titu1994 / PyCTakesParser

Utilities to parse the output of cTAKES
MIT License
10 stars 5 forks source link

Fix boolean safe cast error #4

Closed mccullen closed 4 years ago

mccullen commented 4 years ago

Hello,

Nice work with this package. I just noticed that everything in the "generic" output column was true even though all my values were actually "false". I fixed it in my fork. Casting any non-empty string to a bool (including"false") returns True so you can't rely on the boolean cast to do what you want.

titu1994 commented 4 years ago

Thanks for the fix !

mccullen commented 4 years ago

No problem.