search

titu1994 / keras-efficientnets

Keras Implementation of EfficientNets
MIT License
187 stars 63 forks source link

Update config.py #19

Closed Cyril9227 closed 5 years ago

Cyril9227 commented 5 years ago

Fixed a mistake : block.identity_skip instead of block.id_skip

Updated get_default_block_list() to use serialized block args

titu1994 commented 5 years ago

Thank you for the fix. May I ask why the block args have been replaced by parsing the args ? They are equivalent, otherwise model weights would not be loaded.

Cyril9227 commented 5 years ago

Thank you for your quick feedback.

It is strictly equivalent as you said but now it makes use of the code you already wrote so it might be more coherent with your file and it also might be easier for a newcomer to understand how to use this code to serialize the args.

titu1994 commented 5 years ago

While valid, I manually wrote the args as an example for extension. In cases like Mixnets where there are too many parameters it makes sense to use the string encoding directly but not for this one.

If you would revert this edit, I'll merge the commit asap.

Cyril9227 commented 5 years ago

Sure, edit should be reverted now

titu1994 commented 5 years ago

Thank you for the fix !