titu1994 / keras-one-cycle

Implementation of One-Cycle Learning rate policy (adapted from Fast.ai lib)
MIT License
285 stars 79 forks source link

Don't support tensorflow Datasets when use validation #25

Open makecent opened 4 years ago

makecent commented 4 years ago

Currently, it seems this tool suppose validation to be NumPy arrays or Keras generator, while the tensorflow.data.Dataset is also one of the most frequently used input data structure which is not supported by this tool. I notice that the raised error comes from indexing, counting and sampling on validation dataset which belongs to tf.data.Dataset class. This should be very easy to solve. Could you please add this feature?

titu1994 commented 4 years ago

Since it's so easy to solve I urge you to send a PR.