titus-ong / chordparser

A Python 3 package that provides a musical framework to analyse chords
MIT License
12 stars 2 forks source link

Duck typing #11

Closed titus-ong closed 4 years ago

titus-ong commented 4 years ago

Resolves #1, #6, #7 , #8 . Functions of ChordAnalyser that involve Roman have been ported over to ChordRomanConverter, but there's still work to be done in converting romans to chords.

Removed most, if not all, instances of static typing.

Regex parsing logic in ChordEditor is much more distinct and clearer now, methods are now reusable without having to repeat a regex query.

Quality has been designated a new class for easier parsing within the Chord and ChordRomanConverter class.