search

titus-ong / chordparser

A Python 3 package that provides a musical framework to analyse chords
MIT License
12 stars 2 forks source link

Clean code #39

Open titus-ong opened 4 years ago

titus-ong commented 4 years ago

Revamping entire architecture of chordparser. Editors are removed (did way too much in one class) and are changed for music classes to use composition on their editors. Some classes have been split into multiple smaller classes for clearer definition of responsibility. Enums have been used for notation. Methods, variables etc. are now defined with more meaningful names for easier reading of code. See the planned architecture at https://app.creately.com/diagram/mgDA6MoHqV7/edit. May not be entirely up-to-date but the structure is similar.

titus-ong commented 4 years ago

Currently implemented #9 - available in the utils folder.