tituschewxj / pe

0 stars 0 forks source link

Duplicate names should be allowed #6

Open tituschewxj opened 2 months ago

tituschewxj commented 2 months ago

Current Behaviour

From the user guide, it states that duplicate names are not allowed:

image.png

Why this is an issue

It is possible that two different people have the same names.

I put this as low instead of medium, as I believe that there is a simple but inconvenient workaround which is to put a number in the name to differentiate two people with the same name, and also because it is rare, but still possible for this to happen.

image.png

Expected Behaviour

Allowing two people with the same name should be allowed automatically, without needing to perform such a workaround.

nus-pe-script commented 2 months ago

Team's Response

We appreciate your feedback on the issue of adding two different students with the same name. This is a deliberate design decision to protect the data integrity of the Application.

As noted in the Developer Guide, the application is designed for a career coach at NUS SoC:

Rayson is a career guidance coach at the National University of Singapore (NUS) and is attached to the School of Computing (SoC) to provide computing students with career advice.

  1. While the current system design does not allow for duplicate names - a simple workaround (as you have mentioned) is to manually append a different identifier to the end of the patient's name.
  2. The team believes that there is a low chance of a two students with the same name (birthday paradox) occurring within the application - and if this incident does occur, say there already exists a patient with the name of "Timothy Lim", then automatically appending a "Timothy Lim (1)" to the next user might be confusing for the User.

Once again, we thank you for your feedback.

Have a Nice Day.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]