search

titusfortner / webdrivers

Keep your Selenium WebDrivers updated automatically
MIT License
595 stars 110 forks source link

Add executables for chromedriver and geckodriver #120

Closed HarlemSquirrel closed 5 years ago

HarlemSquirrel commented 5 years ago

This adds executables similar to chromedriver-helper and geckodriver-helper 

➤  bin/webdrivers-chromedriver --version                                                                                                                                          130 ↵
2019-05-14 16:32:54 WARN Webdrivers Driver caching is turned off in this version, but will be enabled by default in 4.x. Set the value with `Webdrivers#cache_time=` in seconds
ChromeDriver 74.0.3729.6 (255758eccf3d244491b8a1317aa76e1ce10d57e9-refs/branch-heads/3729@{#29})

➤  bin/webdrivers-geckodriver --version 
2019-05-14 16:33:03 WARN Webdrivers Driver caching is turned off in this version, but will be enabled by default in 4.x. Set the value with `Webdrivers#cache_time=` in seconds
geckodriver 0.24.0 ( 2019-01-28)

The source code of this program is available from
testing/geckodriver in https://hg.mozilla.org/mozilla-central.

This program is subject to the terms of the Mozilla Public License 2.0.
You can obtain a copy of the license at https://mozilla.org/MPL/2.0/.
twalpole commented 5 years ago

I'm wondering what the use case for these is (especially since they wouldn't be using any settings made in an application that installed them)?

HarlemSquirrel commented 5 years ago

For me, mostly a nice way to check the running version of the driver.

Kevin McCormack Full Stack Web Developer HarlemSquirrel.github.io

On Thu, May 16, 2019, 3:11 PM Thomas Walpole notifications@github.com wrote:

I'm wondering what the use case for these is?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/titusfortner/webdrivers/pull/120?email_source=notifications&email_token=ABRFV5ZKVVYRPZIQJTN5X7DPVWWVLA5CNFSM4HM5OO72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVSZB2Q#issuecomment-493195498, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRFV54YEYQ2VJZU4GURY73PVWWVLANCNFSM4HM5OO7Q .

twalpole commented 5 years ago

Ok, but since it wouldn't actually be loading things like the required version, or install dir, specified in an app, and if you haven't specified a required version webdrivers would be automatically updating it when the tests are run - does it actually provide useful info?

HarlemSquirrel commented 5 years ago

I'm currently using something similar with chromedriver-helper and geckodriver-helper to display the version in use on CircleCI to assist in debugging. I see you're point so perhaps for this a better approach might be to print the version loaded by calling Webdrivers::Chromedriver.desired_version.

kapoorlakshya commented 5 years ago

might be to print the version loaded by calling Webdrivers::Chromedriver.desired_version.

@HarlemSquirrel Webdrivers::Chromedriver.current_version will give you that.

titusfortner commented 5 years ago

Would it make sense to add a rake task webdrivers:chromedriver:version that outputs it?

HarlemSquirrel commented 5 years ago

Rake tasks to display versions should work fine for my use case. If no one else sees a use for these executable additions then we can close this.

titusfortner commented 5 years ago

Merged with #117