search

titusfortner / webdrivers

Keep your Selenium WebDrivers updated automatically
MIT License
593 stars 111 forks source link

Update RuboCop version #178

Closed utkarsh2102 closed 4 years ago

utkarsh2102 commented 4 years ago

Hi @kapoorlakshya,

Thanks for taking care of this so far! :rocket: However, there was one offense left, which is what this PR fixes. (and also updates to use latest RuboCop!

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>

kapoorlakshya commented 4 years ago

Hi @utkarsh2102, thank you for your contribution!

I just fixed the Metrics/AbcSize violation in IEdriver#downloads (see d43c29fcc30f3d110b30b846c66dc1bc950931f1). Can you please revert the file exclusion here?

I also fixed the unit test failure blocking your PR (see 6d398625228a0df0432a85d96b73fa0a49726614), so please rebase on top of master and push. I'd be happy to approve and merge after. Thanks again!

utkarsh2102 commented 4 years ago

Oh wow, your fix for the violation is pretty neat! :100:

kapoorlakshya commented 4 years ago

@utkarsh2102 Thank you for updating the PR! Merging...