search

titusfortner / webdrivers

Keep your Selenium WebDrivers updated automatically
MIT License
593 stars 111 forks source link

Add support for Apple M1 architecture (chromedriver) #193

Closed MichaelHoste closed 3 years ago

MichaelHoste commented 3 years ago

Fixes #191

I hope it's the correct approach.

It's still compatible with Chromedriver versions lower than 87.0.4280.88 but it will then fallback to the Intel version of Chrome.

MichaelHoste commented 3 years ago

I did what you suggested, it made sense!

I first tried to create a separate method for the storage file name, but since we need to pass version with it, it was becoming too verbose and confusing for something that was already quite easy to read and understand. I'm not sure it was better.

kapoorlakshya commented 3 years ago

@MichaelHoste Thank you for making the changes. Looks good!