titusfortner / webdrivers

Keep your Selenium WebDrivers updated automatically
MIT License
593 stars 111 forks source link

rename Edge classes to support Selenium 4 beta #206

Closed titusfortner closed 3 years ago

titusfortner commented 3 years ago

In Selenium 3.142.7 we used Edge to refer to the old Edge HTML implementation. When we switched to working on Selenium 4 we split them into EdgeChrome and EdgeHtml For Selenium 4 beta, we've dropped support for Edge HTML entirely, so everything that was EdgeChrome is now just Edge.

The current test runs will be passing because the specs skip them incorrectly now. (take a look at skipped tests: https://github.com/titusfortner/webdrivers/runs/1990772141)

This PR renames EdgeChrome to Edge. The only people using this class have been using it with Selenium 4 alpha because it isn't supported at all in the latest production version of Selenium.

This code is not backward compatible with Selenium 4 alpha, but I think the correct response is for those people to update to using Selenium 4 beta rather than this gem giving warnings or upgrade paths.

Any concerns?